-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ChannelConfig
in Channel::new
#511
Replace ChannelConfig
in Channel::new
#511
Conversation
Could you give more details on the use that shows this error? |
The error should show up with something like this: let connection_0_1: Connection = ...;
let ordering = Order::default();
let port_0 = PortId::default();
let port_1 = PortId::default();
let channel_0_1 = Channel::new(connection_0_1, ordering, port_0, port_1)?; The full example that triggered the error is here: https://github.com/vitorenesduarte/ibc-rs/blob/reproduce_bug_rust/bbt/src/main.rs#L74-L80 (the branch is not polished; I can extract the example from there in case it's useful) I just confirmed, and the error can also be triggered using the CLI by replacing
|
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=========================================
+ Coverage 13.6% 29.6% +16.0%
=========================================
Files 69 160 +91
Lines 3752 12797 +9045
Branches 1374 5026 +3652
=========================================
+ Hits 513 3799 +3286
- Misses 2618 8324 +5706
- Partials 621 674 +53
Continue to review full report at Codecov.
|
Yes, that is a chain error and it is expected as there is no module on chain binding to that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Vitor!
* Unify Connection::new and Channel::new * Replace RelayPath argument in Channel::new * Update CHANGELOG * Change Connection::set_connection_id to take a owned value as argument
Description
Instead of updating a partially complete
ChannelConfig
,Channel::new
now constructs theChannelConfig
from scratch given its arguments. I found this API nicer to use.All the other changes are for consistency:
ConnectionConfigSide::new
andChannelConfigSide::new
now have owned values as argumentsConnectionConfig::new
andChannelConfig::new
are deleted as they're no longer usedI also noticed that if I use
PortId::default()
as a port, I get the following error:could not retrieve module from port-id: ports/defaultPort: capability not found
. Is this expected?For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.